Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update of all weights for 2025-01-25-1737769694 #7337

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Auto-update of all weights for 2025-01-25-1737769694

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot added the R0-silent Changes should not be mentioned in any release notes label Jan 25, 2025
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot requested review from a team January 25, 2025 01:48
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12960658092
Failed job name: build-runtimes-polkavm

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12960658076
Failed job name: check-try-runtime

@gui1117
Copy link
Contributor

gui1117 commented Jan 28, 2025

I think the templates are using frame but not all crates have frame as a dependency. So it fails to compile.

Either we add frame as a dependency, to all concerned crates, or we revert the change in the template

@mordamax
Copy link
Contributor

mordamax commented Jan 28, 2025

@gui1117 the goal would be that next time it regenerates - it won't fail. if we revert a change in template, https://github.com/paritytech/polkadot-sdk/pull/6789/files#diff-5a2955b61af496005e95ef8d82448fcd76fd957fe4f382b1a757bdfaf0335dd4 then the multisig will be failing next time again?
or pallet_multisig should've used other template based on umbrella crate https://github.com/paritytech/polkadot-sdk/blob/master/.github/scripts/cmd/cmd.py#L227? I wonder may be the dependencies of the multisig_pallet should've fixed instead so it picks up the right template instead of fixing the old templaet

@gui1117
Copy link
Contributor

gui1117 commented Jan 28, 2025

I see.
Looking again, what I see failing is frame-system, because the dependency frame doesn't exist. But frame-system should better not depend on frame to avoid a cyclic dependency.

And the template substrate/.maintain/frame-weight-template.hbs is using frame.

system should not use frame.

Is there a reason substrate/.maintain/frame-weight-template.hbs is using frame and not frame-support.
EDIT: yes it seems multisig_pallet should be fixed and we shouldn't change the old template

@kianenigma
Copy link
Contributor

The weight generation script should inspect the crate, and make a decision about the template based on:

  1. if frame is a dependency
  2. if not.

I have not seen the PR, but this should work in practice. @gui1117 does this make sense?

@mordamax
Copy link
Contributor

Here's a PR fixing a template issue #7362
I will re-start generation all pallets once ☝️ merged

@mordamax mordamax closed this Jan 28, 2025
@gui1117
Copy link
Contributor

gui1117 commented Jan 29, 2025

The weight generation script should inspect the crate, and make a decision about the template based on:

1. if `frame` is a dependency

2. if not.

I have not seen the PR, but this should work in practice. @gui1117 does this make sense?

Yes, the template were changed to always use frame in both cases. This should be now fixed. we will see if there is any error remaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants